Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#switch-to-eslint

or load it into the REPL:
https://rollupjs.org/repl/?pr=4085

Codecov Report

Merging #4085 (5ac6024) into master (551e34a) will increase coverage by 0.00%.
The diff coverage is 97.79%.

@@           Coverage Diff           @@
##           master    #4085   +/-   ##
=======================================
  Coverage   98.00%   98.01%           
=======================================
  Files         201      201           
  Lines        6981     6987    +6     
  Branches     2049     2051    +2     
=======================================
+ Hits         6842     6848    +6     
  Misses         66       66           
  Partials       73       73           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 551e34a...5ac6024. Read the comment docs.

We've got this https://github.com/rollup/eslint-config-rollup which the plugins repo uses here https://github.com/rollup/plugins/blob/master/.eslintrc.js#L2. It needs some love and a few updates (it's on my todo list) but it's pretty solid.

Thanks for pointing that out! I think it would be good to align eventually (which should not be too difficult once this PR is merged), but there are a few things in this config I am not 100% sure about. Mostly also the fact that it does not extend any other "recommended" configs which on the one hand makes it more stable, but on the other hand drives up maintenance overhead.

Still, probably no hard arguments against adopting it. I would still stick with the given config for now as it is very close to what we had before. If you ping me once you update the other config, I will move over Rollup core to use it as well.