Properly include reexports for implicit dependencies#3688
Merged
lukastaegert merged 1 commit intomasterfrom Jul 22, 2020
Merged
Properly include reexports for implicit dependencies#3688lukastaegert merged 1 commit intomasterfrom
lukastaegert merged 1 commit intomasterfrom
Conversation
Collaborator
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #3688 +/- ##
=========================================
Coverage ? 96.78%
=========================================
Files ? 183
Lines ? 6319
Branches ? 1843
=========================================
Hits ? 6116
Misses ? 105
Partials ? 98
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #3683
Description
When an implicitly dependent chunk contained reexports from other chunks that were not actually used in that chunk, then the reexporting modules were not properly linked as a dependency to the implicit entry chunk. This resulted in missing exports in some cases and weird errors in others.
This fixes this by using the same logic as for regular and dynamic entry points here (which was forgotten for implicit entry points).