Support backslash escaping, retain exact newline escaping#3638
Merged
lukastaegert merged 1 commit intomasterfrom Jun 17, 2020
Merged
Support backslash escaping, retain exact newline escaping#3638lukastaegert merged 1 commit intomasterfrom
lukastaegert merged 1 commit intomasterfrom
Conversation
Collaborator
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #3638 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 183 183
Lines 6244 6246 +2
Branches 1830 1831 +1
=======================================
+ Hits 6028 6030 +2
Misses 107 107
Partials 109 109
Continue to review full report at Codecov.
|
lukastaegert
approved these changes
Jun 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This adds backslash escaping as well to the recent escaping work.
I've also reverted to the direct newline escaping over the table approach here, but we can add back the table too if you prefer.
I've also added an extra check in the escaping function to avoid any replacement if escaping is unnecessary. This is a super minor mostly theoretical pref improvement to avoid copying strings.