Handle generating outputs with non-inlined dynamic imports after inlined ones#4589
Merged
lukastaegert merged 1 commit intomasterfrom Jul 27, 2022
Merged
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#non-inlined-import-after-inlinedor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4589 +/- ##
=======================================
Coverage 98.86% 98.86%
=======================================
Files 209 209
Lines 7344 7345 +1
Branches 2098 2098
=======================================
+ Hits 7261 7262 +1
Misses 27 27
Partials 56 56
Help us with your feedback. Take ten seconds to tell us how you rate us. |
4fce640 to
2d76951
Compare
This was referenced Jul 27, 2022
2d76951 to
c4355bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
inlineDynamicImports: truetheninlineDynamicImports: false#4586Description
The problem was that when Rollup generated an output with
inlineDynamicImports: true, it would leave a flag on the (shared) ImportExpression AST node that would mark it isinlinedwhich would not be removed for the next output. The result was that for the next output, the import would be rendered both as "inlined" and as "non-inlined", resulting in an error. The fix was indeed simple.Admittedly, the state handling behind this is not ideal, but resolving this is a much bigger topic for another time.