Introduce maxParallelFileOps to limit parallel writes#4570
Merged
lukastaegert merged 1 commit intomasterfrom Jul 15, 2022
Merged
Introduce maxParallelFileOps to limit parallel writes#4570lukastaegert merged 1 commit intomasterfrom
lukastaegert merged 1 commit intomasterfrom
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#max-parallel-file-opsor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4570 +/- ##
=======================================
Coverage 98.87% 98.87%
=======================================
Files 209 209
Lines 7346 7350 +4
Branches 2098 2100 +2
=======================================
+ Hits 7263 7267 +4
Misses 27 27
Partials 56 56
Continue to review full report at Codecov.
|
83e6d2a to
b2a7d58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Previously, we added --maxParallelFileReads to limit how many parallel files to read on systems with restricted file handles. This PR replaces this (actually soft-deprecates the previous option) with a --maxParallelFileOps option which will also limit writing chunks to disk, as you can face a similar scenario e.g. when preserving modules.