Skip to content

Add exports exception for loadConfigFile#4483

Merged
lukastaegert merged 2 commits intomasterfrom
gh-4460-rollup-package-exports
Apr 30, 2022
Merged

Add exports exception for loadConfigFile#4483
lukastaegert merged 2 commits intomasterfrom
gh-4460-rollup-package-exports

Conversation

@lukastaegert
Copy link
Copy Markdown
Member

@lukastaegert lukastaegert commented Apr 30, 2022 •
edited
Loading

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #4460

Description

As we explicitly state that you can require loadConfigFile without extension in the docs, this will add an explicit exports route for this.

In preparation for the next major release where I would like to remove that hack again, loadConfigFile can now directly be imported as rollup/loadConfigFile as well.

@lukastaegert lukastaegert mentioned this pull request Apr 30, 2022
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 30, 2022 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4460-rollup-package-exports

or load it into the REPL:
https://rollupjs.org/repl/?pr=4483

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 30, 2022 •
edited
Loading

Codecov Report

Merging #4483 (beb80ac) into master (edd971e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4483   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files         205      205           
  Lines        7331     7331           
  Branches     2082     2082           
=======================================
  Hits         7240     7240           
  Misses         33       33           
  Partials       58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd971e...beb80ac. Read the comment docs.

@lukastaegert lukastaegert enabled auto-merge (squash) April 30, 2022 13:29
@lukastaegert lukastaegert disabled auto-merge April 30, 2022 13:29
@lukastaegert lukastaegert merged commit 51972b0 into master Apr 30, 2022
@lukastaegert lukastaegert deleted the gh-4460-rollup-package-exports branch April 30, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

require('rollup/dist/loadConfigFile') causes unexpected ESM-related error

1 participant

@lukastaegert