Do not track side-effect-free array methods as side effects#4103
Merged
lukastaegert merged 1 commit intomasterfrom May 27, 2021
Merged
Do not track side-effect-free array methods as side effects#4103lukastaegert merged 1 commit intomasterfrom
lukastaegert merged 1 commit intomasterfrom
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-4100-no-side-effect-array-methodsor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4103 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 201 201
Lines 7036 7037 +1
Branches 2063 2063
=======================================
+ Hits 6897 6898 +1
Misses 66 66
Partials 73 73
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
#4100 (but does not fully resolve it)
Description
This will no longer track calling array builtin methods such as
filteras side-effects: REPLNote that when the array itself is later passed to a function (like
console.log), Rollup will still optimise as it cannot track if thefiltermethods was overwritten.