Allow treeshaking of arguments of functions that are returned by conditional expressions#3680
Merged
lukastaegert merged 1 commit intomasterfrom Jul 18, 2020
Merged
Conversation
…itional expressions
Collaborator
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via or load it into the REPL: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #3674
Description
This will track function identity through conditional expressions with regard to tree-shaking function arguments as in this example: https://rollupjs.org/repl/?circleci=12359&shareable=JTdCJTIybW9kdWxlcyUyMiUzQSU1QiU3QiUyMm5hbWUlMjIlM0ElMjJtYWluLmpzJTIyJTJDJTIyY29kZSUyMiUzQSUyMmZ1bmN0aW9uJTIwaWdub3JpbmdBcmdzJTIwKCklMjAlN0IlMjAlNUNuJTIwJTIwcmV0dXJuJTIwJ25vJTIwYXJncyclM0IlNUNuJTdEJTVDbiU1Q25mdW5jdGlvbiUyMHRha2luZ0FyZ3MoYXJnKSUyMCU3QiU1Q24lMjAlMjByZXR1cm4lMjBhcmclM0IlNUNuJTdEJTVDbiU1Q25jb25zdCUyMGhhbmRsZXIlMjAlM0QlMjBmYWxzZSUyMCUzRiUyMHRha2luZ0FyZ3MlMjAlM0ElMjBpZ25vcmluZ0FyZ3MlM0IlNUNuJTVDbmNvbnNvbGUubG9nKGhhbmRsZXIoJ3Nob3VsZCUyMGJlJTIwcmVtb3ZlZCcpKSUzQiUyMiUyQyUyMmlzRW50cnklMjIlM0F0cnVlJTdEJTVEJTJDJTIyb3B0aW9ucyUyMiUzQSU3QiUyMmZvcm1hdCUyMiUzQSUyMmVzJTIyJTJDJTIybmFtZSUyMiUzQSUyMm15QnVuZGxlJTIyJTJDJTIyYW1kJTIyJTNBJTdCJTIyaWQlMjIlM0ElMjIlMjIlN0QlMkMlMjJnbG9iYWxzJTIyJTNBJTdCJTdEJTdEJTJDJTIyZXhhbXBsZSUyMiUzQW51bGwlN0Q=