Do not include the whole namespace when illegally mutating a namespace#3637
Merged
lukastaegert merged 2 commits intomasterfrom Jun 17, 2020
Merged
Do not include the whole namespace when illegally mutating a namespace#3637lukastaegert merged 2 commits intomasterfrom
lukastaegert merged 2 commits intomasterfrom
Conversation
9 tasks
Collaborator
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #3637 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 183 183
Lines 6244 6244
Branches 1830 1831 +1
=======================================
Hits 6028 6028
Misses 107 107
Partials 109 109
Continue to review full report at Codecov.
|
guybedford
approved these changes
Jun 15, 2020
Contributor
guybedford
left a comment
There was a problem hiding this comment.
Thanks for fixing this up!
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
#3633
Description
This will refine how we handle mutating namespace objects in that this no longer includes the whole namespace but only the mutated prop. Note that it will still (unnecessarily) include the whole namespace when mutating a missing prop but I found it too much effort to optimize for this rare condition that already displays two (!) warnings.