Skip to content

fix(commonjs): Keep the shebang at the top of the file content#1610

Merged
shellscape merged 1 commit intorollup:masterfrom
TrickyPi:xiaopi-shebang
Oct 15, 2023
Merged

fix(commonjs): Keep the shebang at the top of the file content#1610
shellscape merged 1 commit intorollup:masterfrom
TrickyPi:xiaopi-shebang

Conversation

@TrickyPi
Copy link
Member

Rollup Plugin Name: commonjs

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:
resolves #1602

Description

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@shellscape shellscape merged commit cb579c8 into rollup:master Oct 15, 2023
@shellscape
Copy link
Collaborator

thanks!

@privatenumber
Copy link

Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

commonjs plugin errors on hashbangs

5 participants