feat(node-resolve): pass original importee to secondary resolve#1557
feat(node-resolve): pass original importee to secondary resolve#1557shellscape merged 6 commits intorollup:masterfrom jchip:master
Conversation
|
Thanks for the PR. Could you please provide a much more detailed explanation on what this PR is adding, solving, or fixing for you, with examples? |
|
@shellscape We want to build plugins as part of our dev tools to offer module analytics and stats. One use case is exploring a different approach to implementing module federation on rollup. For that, at our plugin, we need two pieces of information:
Having the information in 1 and 2 above at the same time in a plugin is crucial to implement some of the tooling aspect we are exploring. So the changes in this PR updates node-resolve to pass them both to further plugins as it does its second resolve. |
lukastaegert
left a comment
There was a problem hiding this comment.
Looks good to me and might indeed be useful. The only thing I hope is that we can use this chance to document this feature (and the "resolved" feature) in the Readme so that people know about it, can you do that?
lukastaegert
left a comment
There was a problem hiding this comment.
Thanks a lot, looks good!
Rollup Plugin Name:
node-resolveThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
pass on original
importeeto other plugins.