Skip to content

fix(commonjs): add classBodyDepth flag#1507

Merged
shellscape merged 2 commits intorollup:masterfrom
TrickyPi:fix/this
Jun 19, 2023
Merged

fix(commonjs): add classBodyDepth flag#1507
shellscape merged 2 commits intorollup:masterfrom
TrickyPi:fix/this

Conversation

@TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented May 27, 2023

Rollup Plugin Name: commonjs

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

resolves #1479

Description

This PR add a new flag classBodyDepth to preserve this in the class.

@TrickyPi
Copy link
Member Author

TrickyPi commented May 28, 2023

the failed test in windows can be fixed by #1507 #1508

@shellscape
Copy link
Collaborator

Thanks for the PRs. We'll see how #1508 pans out before we move on this.

@shellscape shellscape merged commit b844adb into rollup:master Jun 19, 2023
@shellscape
Copy link
Collaborator

thanks!

@TrickyPi TrickyPi deleted the fix/this branch June 19, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[@rollup/plugin-commonjs] Incorrect compilation of this in field declaration inside a class.

4 participants