fix(node-resolve): bump is-builtin-module version, imports with a trailing slash#1424
Merged
shellscape merged 3 commits intorollup:masterfrom Apr 4, 2023
Merged
fix(node-resolve): bump is-builtin-module version, imports with a trailing slash#1424shellscape merged 3 commits intorollup:masterfrom
shellscape merged 3 commits intorollup:masterfrom
Conversation
shellscape
approved these changes
Jan 31, 2023
Collaborator
shellscape
left a comment
There was a problem hiding this comment.
Looks good, thanks for the additional test!
tada5hi
approved these changes
Mar 20, 2023
Collaborator
|
@rsweeney21 I was all set to merge this but a prior PR has updated our lockfile. Please rebase to |
Collaborator
|
I was actually able to resolve the conflict using the web editor. |
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
node-resolveThis PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
#1211
Description
Adding a trailing slash to a module name in an import statement is the convention for telling node to use the local module with that name, rather than the builtin module with the same name.
For an example, see the docs for punycode which is available as both a builtin and standalone module for node.
The is-builtin-module package did not respect this convention. A fix was made and released in is-builtin-modules v3.2.1. This change bumps the version of the dependency and adds a test case to verify that import statements with a trailing slash are not treated as builtin modules by the node-resolve package.