feat(node-resolve): Add the ability to pass a function into resolveOnly#1152
Merged
shellscape merged 2 commits intorollup:masterfrom Apr 11, 2022
TotalTechGeek:master
Merged
feat(node-resolve): Add the ability to pass a function into resolveOnly#1152shellscape merged 2 commits intorollup:masterfrom TotalTechGeek:master
shellscape merged 2 commits intorollup:masterfrom
TotalTechGeek:master
Conversation
…ly to resolve issue #1150
tjenkinson
approved these changes
Mar 28, 2022
Member
tjenkinson
left a comment
There was a problem hiding this comment.
Lgtm! I think the empty array behaviour is the same but just wanted to double check
TotalTechGeek
commented
Mar 28, 2022
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Rollup Plugin Name:
node-resolveThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
#1150
Description
Currently, the
resolveOnlyproperty allows you to pass in an array of strings or regular expressions to validate if a module should be bundled in.I had a use case where I wanted to bundle in everything except for certain dependencies. (node-rdkafka, sqlite3).
I've extended the resolveOnly property to allow developers more control. With this PR, it should be possible to pass in a function into
nodeResolveto override the check that takes place, thus allowing something like the following: