test(node-resolve): add tests for mixing custom exportConditions with browser: true#1043
Merged
shellscape merged 1 commit intomasterfrom Dec 13, 2021
Conversation
guybedford
approved these changes
Nov 16, 2021
Contributor
guybedford
left a comment
There was a problem hiding this comment.
Thanks for posting these. Note the lint issue / console.log.
40c5f41 to
28b14c7
Compare
Member
Author
|
@guybedford fixed 🤦 |
Member
Author
|
Since this is approved and CI passes - can I just land this? I'm slightly unsure and I don't want to get in the way of The Process 😉 |
exportConditions with browser: trueexportConditions with browser: true
shellscape
approved these changes
Dec 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
@rollup/plugin-node-resolveThis PR contains:
Are tests included?
Breaking Changes?
Description
I was wondering if this would work correctly - I've figured out that the quickest way to found out would be to check the test suite but I couldn't find any
exportConditions-related test. The only place where "exportCondition:" string appears in the codebase is this type test:plugins/packages/node-resolve/test/types.ts
Line 14 in 53776ee
Since it felt like such tests are missing, I've decided to just add them 😉