fix(node-resolve): Revert respect if other plugins resolve the resolution to a different id

lukastaegert · lukastaegert · commit ae59cebbbd17 · 2022-05-01T07:11:58.000+02:00
This reverts commit f8d4c44.
diff --git a/packages/node-resolve/src/index.js b/packages/node-resolve/src/index.js
@@ -281,11 +281,6 @@ export function nodeResolve(opts = {}) {
           if (resolvedResolved.external) {
             return false;
           }
-          // Allow other plugins to take over resolution. Rollup core will not
-          // change the id if it corresponds to an existing file
-          if (resolvedResolved.id !== resolved.id) {
-            return resolvedResolved;
-          }
           // Pass on meta information added by other plugins
           return { ...resolved, meta: resolvedResolved.meta };
         }
diff --git a/packages/node-resolve/test/test.js b/packages/node-resolve/test/test.js
@@ -1,4 +1,4 @@
-import { join, resolve, dirname } from 'path';
+import { join, resolve } from 'path';
 
 import test from 'ava';
 import { rollup } from 'rollup';
@@ -581,31 +581,3 @@ test('passes on meta information from other plugins', async (t) => {
     ]
   });
 });
-
-test('allow other plugins to take over resolution', async (t) => {
-  await rollup({
-    input: 'entry/main.js',
-    onwarn: failOnWarn(t),
-    plugins: [
-      nodeResolve(),
-      {
-        name: 'change-resolution',
-        resolveId(importee) {
-          if (importee.endsWith('main.js')) {
-            return {
-              id: join(dirname(importee), 'other.js'),
-              meta: { 'change-resolution': 'changed' }
-            };
-          }
-          return null;
-        },
-
-        load(id) {
-          const info = this.getModuleInfo(id);
-          t.is(info.id, join(__dirname, 'fixtures', 'entry', 'other.js'));
-          t.deepEqual(info.meta, { 'change-resolution': 'changed' });
-        }
-      }
-    ]
-  });
-});

Original file line number	Diff line number	Diff line change
`@@ -281,11 +281,6 @@ export function nodeResolve(opts = {}) {`
`281`	`281`	`if (resolvedResolved.external) {`
`282`	`282`	`return false;`
`283`	`283`	`}`
`284`		`- // Allow other plugins to take over resolution. Rollup core will not`
`285`		`- // change the id if it corresponds to an existing file`
`286`		`- if (resolvedResolved.id !== resolved.id) {`
`287`		`- return resolvedResolved;`
`288`		`- }`
`289`	`284`	`// Pass on meta information added by other plugins`
`290`	`285`	`return { ...resolved, meta: resolvedResolved.meta };`
`291`	`286`	`}`