Add only configuration option to todo rule#5233
Merged
Merged
Conversation
Generated by 🚫 Danger |
only configuration to todo ruleonly configuration option to todo rule
SimplyDanny
requested changes
Sep 24, 2023
SimplyDanny
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for taking this up!
SimplyDanny
reviewed
Sep 25, 2023
SimplyDanny
reviewed
Sep 25, 2023
985918b to
0f83da7
Compare
Collaborator
|
Rebased, renamed property and moved changelog entry to new |
SimplyDanny
approved these changes
Sep 26, 2023
|
Just a word of thanks, to both of you @gibachan and @SimplyDanny , for the speedy implementation of this requested feature. 💚 |
KS1019
pushed a commit
to KS1019/SwiftLint
that referenced
this pull request
Oct 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5232
This PR adds an
onlyconfiguration option to thetodorule.This option allows you to choose whether only FIXME or TODO will be warned.