🐞 fix #12097 Use dirty fields along with mount names for form reset with keepDirtyValues (#12097)#12211
Merged
bluebill1049 merged 1 commit intoreact-hook-form:masterfrom Sep 7, 2024
Conversation
- The logic for dirty value checking relies on mounts but array values modified via setValue and shouldDirty didn't satisfy the logic
54ecb64 to
a926460
Compare
Member
|
Nice! you have even included an e2e test. Thank you! |
bluebill1049
approved these changes
Sep 7, 2024
oskarski
pushed a commit
to oskarski/react-hook-form
that referenced
this pull request
Oct 1, 2024
…or form reset with keepDirtyValues (react-hook-form#12211) - The logic for dirty value checking relies on mounts but array values modified via setValue and shouldDirty didn't satisfy the logic Co-authored-by: Rasikh Qadeer <rasikhqadeer98@gmail.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #12097
Make sure to include dirty field names when resetting form and applying dirty values