Skip to content

Reject opening parens within (/) link titles#841

Merged
Martin1887 merged 1 commit intopulldown-cmark:masterfrom
notriddle:notriddle/link-ref-def-title
Feb 3, 2024
Merged

Reject opening parens within (/) link titles#841
Martin1887 merged 1 commit intopulldown-cmark:masterfrom
notriddle:notriddle/link-ref-def-title

Conversation

@notriddle
Copy link
Collaborator

Fixes #840

@Martin1887
Copy link
Collaborator

Thanks! Should not be done also for " and ' delimiters? That is, including tests and code for failing links when the delimiter is one of them only producing a link if they are escaped with a backslash.

@notriddle notriddle force-pushed the notriddle/link-ref-def-title branch from 4b4552f to 55fd2d3 Compare February 3, 2024 15:21
@notriddle
Copy link
Collaborator Author

@Martin1887 Okay, I've added test cases for the " and ' delimiters.

@Martin1887
Copy link
Collaborator

Perfect, so the issue was happening only with parenthesis, anyways they are good regression tests to have :-).

@Martin1887 Martin1887 merged commit f874c08 into pulldown-cmark:master Feb 3, 2024
@notriddle notriddle deleted the notriddle/link-ref-def-title branch February 3, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fuzz result] unbalanced parens are parsed as a link title

2 participants