Do not treat zero-cell rows as valid#812
Merged
Martin1887 merged 1 commit intopulldown-cmark:masterfrom Jan 20, 2024
Merged
Conversation
This brings pulldown-cmark into alignment with GFM.
Collaborator
|
A pity not being aligned with Pandoc, but GFM is the reference here. Thanks! |
notriddle
pushed a commit
to notriddle/pulldown-cmark
that referenced
this pull request
Jan 20, 2024
…ro-cell-row Do not treat zero-cell rows as valid
notriddle
pushed a commit
to notriddle/pulldown-cmark
that referenced
this pull request
Jan 20, 2024
…ro-cell-row Do not treat zero-cell rows as valid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Table rows must have at least one cell. A single pipe, on its own, doesn't count.
The behavior on babelmark is pretty diverse, but this behavior is chosen to align with GFM.
✓ means it treats the zero cell lines with only a pipe as not being valid rows, but otherwise parses as a table.
x means it treats the zero cell lines with only a pipe as a valid row.
? means it does something else.
Link to Babelmark 3 test
Footnotes
Not on babelmark 3. I ran it on https://pandoc.org/try/?params=%7B%22text%22%3A%22%7C+Table+%7C+Header+%7C%5Cn%7C-------%7C--------%7C%5Cn%7C+Table+%7C+Body+++%7C%5Cn%7C%5Cn%7C+Not+++%7C+Enough+%7C%5Cn%5Cn%7C+Table+%7C+Header+%7C%5Cn%7C-------%7C--------%7C%5Cn%7C%5Cn%5Cn%7C%5Cn%7C-------%7C--------%7C%5Cn%7C+Table+%7C+Body+++%7C%5Cn%22%2C%22to%22%3A%22html5%22%2C%22from%22%3A%22gfm%22%2C%22standalone%22%3Afalse%2C%22embed-resources%22%3Afalse%2C%22table-of-contents%22%3Afalse%2C%22number-sections%22%3Afalse%2C%22citeproc%22%3Afalse%2C%22html-math-method%22%3A%22plain%22%2C%22wrap%22%3A%22auto%22%2C%22highlight-style%22%3Anull%2C%22files%22%3A%7B%7D%2C%22template%22%3Anull%7D ↩
Markdown-it changed some time between the version on their playground
https://markdown-it.github.io/#md3=%7B%22source%22%3A%22%7C%20Table%20%7C%20Header%20%7C%5Cn%7C-------%7C--------%7C%5Cn%7C%20Table%20%7C%20Body%20%20%20%7C%5Cn%7C%5Cn%7C%20Not%20%20%20%7C%20Enough%20%7C%5Cn%5Cn%7C%20Table%20%7C%20Header%20%7C%5Cn%7C-------%7C--------%7C%5Cn%7C%5Cn%5Cn%7C%5Cn%7C-------%7C--------%7C%5Cn%7C%20Table%20%7C%20Body%20%20%20%7C%5Cn%22%2C%22defaults%22%3A%7B%22html%22%3Afalse%2C%22xhtmlOut%22%3Afalse%2C%22breaks%22%3Afalse%2C%22langPrefix%22%3A%22language-%22%2C%22linkify%22%3Atrue%2C%22typographer%22%3Atrue%2C%22_highlight%22%3Atrue%2C%22_strict%22%3Afalse%2C%22_view%22%3A%22html%22%7D%7D and the version Babelmark 3 uses. ↩
Multimarkdown and Markdig don't recognize these at tables at all,
even though I know they support pipe tables. ↩ ↩2 ↩3 ↩4 ↩5 ↩6
Maruku swallows much of the text entirely in these test cases. ↩ ↩2 ↩3