Trim spaces off end of parsed lines#785
Merged
Martin1887 merged 1 commit intopulldown-cmark:masterfrom Jan 21, 2024
Merged
Conversation
d20ad18 to
5b52bd6
Compare
Collaborator
|
Very interesting, this was a pending issue for the 0.10 release, thanks! I have to carefully check the changes, and @raphlinus review would also be very appreciated. |
raphlinus
approved these changes
Jan 20, 2024
Collaborator
raphlinus
left a comment
There was a problem hiding this comment.
I haven't gone deep into the logic, but this seems fairly straightforward - the existing behavior is (subtly) buggy, there are tests to cover that, and the author is someone very familiar with the codebase. I'm comfortable with it going in, and if there are problems, hopefully they'll surface in time. Thanks for the work on this!
5b52bd6 to
28165a5
Compare
28165a5 to
a4cdd6a
Compare
Collaborator
|
Perfect, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #715