Skip to content

Fixes rustdoc::bare_urls lint#719

Merged
Martin1887 merged 1 commit intopulldown-cmark:masterfrom
GuillaumeGomez:fix-rustdoc-lint
Sep 25, 2023
Merged

Fixes rustdoc::bare_urls lint#719
Martin1887 merged 1 commit intopulldown-cmark:masterfrom
GuillaumeGomez:fix-rustdoc-lint

Conversation

@GuillaumeGomez
Copy link
Contributor

It fixes this:

warning: this URL is not a hyperlink
 --> src/utils.rs:3:5
  |
3 | //! https://github.com/BenjaminRi/Redwood-Wiki/blob/master/src/markdown_utils.rs.
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use an automatic link instead: `<https://github.com/BenjaminRi/Redwood-Wiki/blob/master/src/markdown_utils.rs.>`
  |
  = note: bare URLs are not automatically turned into clickable links
  = note: `#[warn(rustdoc::bare_urls)]` on by default

warning: this URL is not a hyperlink
 --> src/utils.rs:5:5
  |
5 | //! https://github.com/raphlinus/pulldown-cmark/issues/507.
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use an automatic link instead: `<https://github.com/raphlinus/pulldown-cmark/issues/507.>`
  |
  = note: bare URLs are not automatically turned into clickable links

warning: `pulldown-cmark` (lib doc) generated 2 warnings (run `cargo fix --lib -p pulldown-cmark` to apply 2 suggestions)

@Martin1887
Copy link
Collaborator

Good catch, thanks!

@Martin1887 Martin1887 merged commit dadad5f into pulldown-cmark:master Sep 25, 2023
@GuillaumeGomez GuillaumeGomez deleted the fix-rustdoc-lint branch September 25, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants