Use correct both flag when pushing remaining delimiters to stack#682
Merged
Martin1887 merged 1 commit intopulldown-cmark:masterfrom Jun 29, 2023
Merged
Conversation
Fixes pulldown-cmark#657 Here's the delimiter match-ups that pulldown-cmark made before this commit, annotated to make clear the both flag and the multiple-of-three matching that was erroneously applied: ****foo*bar*baz**** ^^12 2 1 ^^^^ = 6 - - both ***R]*-* ^^1 1 ^ = 3 - both
Collaborator
|
Thanks for your contribution. I need more time to fully understand the emphasis algorithm, but it looks well. Could you take a look, @raphlinus? |
raphlinus
approved these changes
Jun 29, 2023
Collaborator
raphlinus
left a comment
There was a problem hiding this comment.
I believe this change is correct. Good catch!
Collaborator
|
Perfect, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #657
Here's the delimiter match-ups that pulldown-cmark made before this commit, annotated to make clear the both flag and the multiple-of-three matching that was erroneously applied: