Skip to content

fix(cache): handle get_from_cache=None and ensure directory exists#544

Merged
yeisonvargasf merged 1 commit intomainfrom
fix/cache-handling
Jul 4, 2024
Merged

fix(cache): handle get_from_cache=None and ensure directory exists#544
yeisonvargasf merged 1 commit intomainfrom
fix/cache-handling

Conversation

@dylanpulver
Copy link
Copy Markdown
Contributor

  • Added file lock handling for get_from_cache=None
  • Updated to filelock==3.12.2
  • Ensured the cache directory exists
  • Updated write_cache and corresponding tests

Signed-off-by: Dylan Pulver <dylan@safetycli.com>
@dylanpulver dylanpulver force-pushed the fix/cache-handling branch from 01303d2 to edbe6cd Compare July 4, 2024 00:54
Copy link
Copy Markdown
Member

@yeisonvargasf yeisonvargasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yeisonvargasf yeisonvargasf merged commit b2f0a16 into main Jul 4, 2024
dylanpulver added a commit that referenced this pull request Jul 4, 2024
)

Signed-off-by: Dylan Pulver <dylan@safetycli.com>
dylanpulver added a commit that referenced this pull request Jul 9, 2024
author Dylan Pulver <dylanryanpulver@gmail.com> 1719603852 -0400
committer Dylan Pulver <dylanryanpulver@gmail.com> 1720552637 -0400
gpgsig -----BEGIN PGP SIGNATURE-----

 iHUEABYKAB0WIQQVa+zaLSZxm3/LxmooEm7VNVc3KwUCZo2MvQAKCRAoEm7VNVc3
 Kw3EAP0acAlkZ3XYxvP5P8H4rAx4XXhAOp1Sv7OnQu/nbuPhIgEAitluAgNBdtDU
 jrt9pNq7Y1I76KOuKS+8VRewmuYJUQI=
 =bYzZ
 -----END PGP SIGNATURE-----

fix(debug): fix --debug flag and associated tests

- Fix --debug flag functionality
- Add tests using runner.invoke
- Fix and modify fetch_database function
- Ensure all tests pass with appropriate patchings

Fix --debug flag

remove duplicate block

undo linting

remove test_debug file

modify fetch_database

fix(cache): handle get_from_cache=None and ensure directory exists (#544)

Signed-off-by: Dylan Pulver <dylan@safetycli.com>

chore: release 3.2.4 (#545)

refactor: Jeff refactor suggestions

Switch to use main() function

refactor: adjust to cli() and cli_internal()

refactor: fix click group to be on new cli() func

fix: fix function order

fix: fix function order

fix: fix tests for debug flag changes

remove uneeded files

don't call dummy funcs

fix(debug): fix --debug flag and associated tests

- Fix --debug flag functionality
- Add tests using runner.invoke
- Fix and modify fetch_database function
- Ensure all tests pass with appropriate patchings

Fix --debug flag

undo linting
@dylanpulver dylanpulver mentioned this pull request Aug 9, 2024
yeisonvargasf pushed a commit that referenced this pull request Mar 23, 2026
)

Signed-off-by: Dylan Pulver <dylan@safetycli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants