Removed support for tkinter before Python 1.5.2#6549
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Aug 30, 2022
Merged
Removed support for tkinter before Python 1.5.2#6549hugovk merged 1 commit intopython-pillow:mainfrom
hugovk merged 1 commit intopython-pillow:mainfrom
Conversation
Member
|
Wow! Here "new versions" means since April 1999, 23 years ago! Here's where And added to the 1.5.2 NEWS file on 11 Aug 1998: And 1.5.2 was released on 13 April 1999: I think we can safely drop this without a deprecation warning :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pillow/src/_imagingtk.c
Lines 26 to 28 in ad7be55
I saw "for new versions", and wondered how long this message has been there. It turns out, it has been there since the fork from PIL.
The code is used when ImageTk catches an AttributeError, which has also been present since the fork.
Pillow/src/PIL/ImageTk.py
Lines 71 to 85 in ad7be55
interpaddr()added in Python 1.5.2. The last version of PIL supported Python 1.5.2, so it seems likely that the AttributeError catch was there for Python versions < 1.5.2.We no longer support such early versions of Python, so this code can be removed.