Pass SAMPLEFORMAT to libtiff#5848
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Dec 28, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5843
SAMPLEFORMATis currently in theblocklistwhen saving with libtiff.Pillow/src/PIL/TiffImagePlugin.py
Lines 1687 to 1689 in ae7c2cb
The explanation is
Pillow/src/PIL/TiffImagePlugin.py
Lines 1679 to 1680 in ae7c2cb
But
SAMPLEFORMATdoesn't only come from the user. It can also be set by TiffImagePlugin, according to the image format.Pillow/src/PIL/TiffImagePlugin.py
Lines 1477 to 1488 in ae7c2cb
Pillow/src/PIL/TiffImagePlugin.py
Lines 1603 to 1604 in ae7c2cb
So this PR removes
SAMPLEFORMATfromblocklist, allowing the value to be passed to libtiff by TiffImagePlugin's code - but also adding other code to still not allow the user to set it.