Skip to content

Fix 2 buffer overflows in TIFF decoding#4507

Merged
hugovk merged 5 commits intopython-pillow:masterfrom
hugovk:fix_tiff
Apr 1, 2020
Merged

Fix 2 buffer overflows in TIFF decoding#4507
hugovk merged 5 commits intopython-pillow:masterfrom
hugovk:fix_tiff

Conversation

@hugovk
Copy link
Copy Markdown
Member

@hugovk hugovk commented Apr 1, 2020

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2020 •
edited
Loading

Codecov Report

Merging #4507 into master will decrease coverage by 0.63%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4507      +/-   ##
=========================================
- Coverage   89.83%   89.2%   -0.64%     
=========================================
  Files         328     326       -2     
  Lines       40833   40842       +9     
=========================================
- Hits        36683   36433     -250     
- Misses       4150    4409     +259
Flag Coverage Δ
#AppVeyor ?
#GHA_Docker 85.94% <40%> (-0.01%) ⬇️
#GHA_Ubuntu 87.91% <40%> (-0.13%) ⬇️
#GHA_Windows ?
#GHA_macOS 87.03% <40%> (-0.02%) ⬇️
#TravisCI 92.66% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/libImaging/TiffDecode.c 83.33% <40%> (-1.58%) ⬇️
Tests/test_imagewin_pointers.py 7.69% <0%> (-92.31%) ⬇️
Tests/test_imagewin.py 44.23% <0%> (-55.77%) ⬇️
Tests/test_locale.py 73.33% <0%> (-26.67%) ⬇️
src/PIL/ImageWin.py 35.22% <0%> (-25%) ⬇️
Tests/test_file_wmf.py 75% <0%> (-25%) ⬇️
src/PIL/WmfImagePlugin.py 74.62% <0%> (-20.9%) ⬇️
src/PIL/ImageGrab.py 75.86% <0%> (-20.69%) ⬇️
Tests/test_imagefont_bitmap.py 91.3% <0%> (-8.7%) ⬇️
src/PIL/ImageShow.py 83.33% <0%> (-7.85%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7f9e19...2092801. Read the comment docs.

@hugovk
Copy link
Copy Markdown
Member Author

hugovk commented Apr 1, 2020

The 8d4fdf6 commit to "Use actions/checkout@v2 to fix checkout after restarts" isn't helping for Windows:

image

Removing from this PR, can deal with it after the release.

@hugovk
Copy link
Copy Markdown
Member Author

hugovk commented Apr 1, 2020

This is showing some older failed GHA Windows jobs, but also showing the re-runs as green. To double check, here's the same GHA jobs passing on my fork: hugovk#47.

Merging.

@hugovk hugovk merged commit 46f4a34 into python-pillow:master Apr 1, 2020
@hugovk hugovk deleted the fix_tiff branch April 1, 2020 10:33
@hugovk hugovk mentioned this pull request Apr 7, 2020
Merged
@hugovk hugovk mentioned this pull request Jul 15, 2020
Closed
@StatusWrike StatusWrike mentioned this pull request Nov 9, 2020
Closed
@sync-by-unito sync-by-unito Bot mentioned this pull request Feb 1, 2021
Closed
This was referenced Mar 6, 2021
Merged
Open
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Merged
Closed
Closed
Merged
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hugovk @wiredfool