Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: python/mypy
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.7.0
Choose a base ref
...
head repository: python/mypy
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.7.1
Choose a head ref
  • 10 commits
  • 21 files changed
  • 3 contributors

Commits on Nov 13, 2023

  1. Bump version to 1.7.1+dev

    JukkaL committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    fe79a59 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Fix crash on Callable self in __call__ (#16453)

    Fixes #16450
    
    The fix is a bit ad-hoc, but OTOH there is nothing meaningful we can
    infer in such situation, so it is probably OK.
    ilevkivskyi authored and JukkaL committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    f862d3e View commit details
    Browse the repository at this point in the history
  2. Special-case unions in polymorphic inference (#16461)

    Fixes #16451
    
    This special-casing is unfortunate, but this is the best I came up so
    far.
    ilevkivskyi authored and JukkaL committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    4b5b316 View commit details
    Browse the repository at this point in the history
  3. Exclude private attributes from override checks (#16464)

    Fixes #9910
    Fixes #16452
    
    We already exclude private names from override type compatibility checks
    etc., but it looks like some override checks were still performed, we
    need to skip them, since private name is actually a different name in
    subclass.
    
    ---------
    
    Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
    2 people authored and JukkaL committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    88791ca View commit details
    Browse the repository at this point in the history
  4. Fix missing meet case exposed by len narrowing (#16470)

    Fixes #16468
    
    The fix is straightforward.
    
    Btw when fixing this I noticed that we disregard type arguments when
    narrowing, for example:
    ```python
    x: Sequence[int]
    if isinstance(x, tuple):
        reveal_type(x)  # tuple[Any, ...], but should be `tuple[int, ...]`
    ```
    I guess fixing this may be tricky, and it is quite old behavior.
    ilevkivskyi authored and JukkaL committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    5c354c4 View commit details
    Browse the repository at this point in the history
  5. Ignore position if imprecise arguments are matched by name (#16471)

    Fixes #16405
    Fixes #16412
    
    Imprecise argument kinds inference was added a while ago to support
    various edge cases with `ParamSpec`. This feature required mapping
    actual kinds to formal kinds, which is in general undecidable. At that
    time we decided to not add much special-casing, and wait for some real
    use-cases. So far there are two relevant issues, and it looks like both
    of them can be fixed with simple special-casing: ignore argument
    positions in subtyping if arguments can be matched by name. This adds
    minor unsafety, and generally doesn't look bad, so I think we should go
    ahead with it.
    
    ---------
    
    Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
    2 people authored and JukkaL committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    6c8e0cc View commit details
    Browse the repository at this point in the history
  6. Fix crash on strict-equality with recursive types (#16483)

    Fixes #16473
    
    Potentially we can turn this helper function into a proper visitor, but
    I don't think it is worth it as of right now.
    
    ---------
    
    Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
    2 people authored and JukkaL committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    661adb7 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Fix polymorphic application for callback protocols (#16514)

    Fixes #16512
    
    The problems were caused if same callback protocol appeared multiple
    times in a signature. Previous logic confused this with a recursive
    callback protocol.
    ilevkivskyi authored and JukkaL committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    e6399d1 View commit details
    Browse the repository at this point in the history
  2. [mypyc] Fix regression with nested functions (#16484)

    Fixes #16480
    
    Fix is straightforward, but also suspicious, since I am not sure how it
    ever worked without this.
    ilevkivskyi authored and JukkaL committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    c10e173 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Configuration menu
    Copy the full SHA
    6b3c418 View commit details
    Browse the repository at this point in the history
Loading