Move decimal.Decimal validation to _generate_schema.py#9977
Merged
sydney-runkle merged 1 commit intomainfrom Jul 25, 2024
Merged
Move decimal.Decimal validation to _generate_schema.py#9977sydney-runkle merged 1 commit intomainfrom
decimal.Decimal validation to _generate_schema.py#9977sydney-runkle merged 1 commit intomainfrom
Conversation
CodSpeed Performance ReportMerging #9977 will not alter performanceComparing Summary
|
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
adriangb
reviewed
Jul 25, 2024
Comment on lines
+1809
to
+1815
| @pytest.mark.xfail( | ||
| reason=( | ||
| "We allow python validation functions to wrap the type if the constraint isn't valid for the type. " | ||
| "An error isn't raised for an int or float annotated with this same invalid constraint, " | ||
| "so it's ok to mark this as xfail for now, but we should improve all of them in the future." | ||
| ) | ||
| ) |
Member
There was a problem hiding this comment.
FWIW I do think we could special case something like Annotated[float, Field(max_len=10)] to raise an error at schema building time. If we're 100% sure the constraint makes no sense we can raise an error. But in the case of Annoated[float, AfterValidator(...), Field(max_len=10)] or whatever that we can't.
Contributor
Author
There was a problem hiding this comment.
Agreed, I think that should be addressed in a different PR though 👍
adriangb
approved these changes
Jul 25, 2024
This was referenced Jul 26, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Along the same lines as #9975 and #9976.
I've marked one test as xfail - we're no longer checking for the appropriate decimal constraints here, but this isn't a reflection of a problem with decimal, but rather our known annotated metadata application process. I've explained this reason in the xfail comment, and plan to write up a report discussing how we apply annotated metadata and the current shortcomings.
Upon
codspeedcompletion, I'm seeing a 7% improvement on this function: https://codspeed.io/pydantic/pydantic/branches/move-dec. We're slowly chipping away!