⚡️ Speed up ModelPrivateAttr.__set_name__() by 18% in pydantic/fields.py#9841
Merged
sydney-runkle merged 1 commit intopydantic:mainfrom Jul 17, 2024
Conversation
Certainly! Below is the optimized version of the given Python program. The improvements involve reducing redundant attribute lookups and rearranging some logic to be more efficient. ### Changes and Improvements. 1. **Reduced Redundant Lookups in Equality Check**. - Stored the comparison result in-line rather than fetching attributes multiple times. 2. **Optimized `__set_name__` Method**. - Minimized calls to `hasattr` and `getattr` by reducing redundant attribute access. These optimizations ensure that the runtime and memory usage are more efficient, without changing the functionality of the code.
CodSpeed Performance ReportMerging #9841 will not alter performanceComparing Summary
|
sydney-runkle
approved these changes
Jul 17, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Clean! Great, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
📄
ModelPrivateAttr.__set_name__()inpydantic/fields.py📈 Performance improved by
18%(0.18xfaster)⏱️ Runtime went down from
20.6 microsecondsto17.4 microsecondsExplanation and details
Certainly! Below is the optimized version of the given Python program. The improvements involve reducing redundant attribute lookups and rearranging some logic to be more efficient.
Changes and Improvements.
Reduced Redundant Lookups in Equality Check.
Optimized
__set_name__Method.hasattrandgetattrby reducing redundant attribute access.These optimizations ensure that the runtime and memory usage are more efficient, without changing the functionality of the code.
Correctness verification
The new optimized code was tested for correctness. The results are listed below.
🔘 (none found) − ⚙️ Existing Unit Tests
✅ 10 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
🔘 (none found) − ⏪ Replay Tests
Checklist