Skip to content

Fix type hint on IpvAnyAddress#9640

Merged
sydney-runkle merged 3 commits intomainfrom
ipvany-type-checking
Jun 12, 2024
Merged

Fix type hint on IpvAnyAddress#9640
sydney-runkle merged 3 commits intomainfrom
ipvany-type-checking

Conversation

@sydney-runkle
Copy link
Copy Markdown
Contributor

Fix #9638

@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label Jun 12, 2024
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jun 12, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: b96d95a
Status: ✅  Deploy successful!
Preview URL: https://1424199c.pydantic-docs.pages.dev
Branch Preview URL: https://ipvany-type-checking.pydantic-docs.pages.dev

View logs

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 12, 2024

CodSpeed Performance Report

Merging #9640 will not alter performance

Comparing ipvany-type-checking (b96d95a) with main (055f900)

Summary

✅ 13 untouched benchmarks

@sydney-runkle sydney-runkle requested a review from adriangb June 12, 2024 13:43
@haoyun
Copy link
Copy Markdown
Contributor

haoyun commented Jul 29, 2024

It seems that only IPvAnyNetwork was fixed in the commit, but IPvAnyAdress still has the problem mentioned in #6522 and #9638.

Something similar like

IPvAnyAddressType = "IPv4Address | IPv6Address"

if TYPE_CHECKING:
    IPvAnyAddress = IPvAnyAddressType
else:
    class IPvAnyAddress:
        ....

should be done too, as well as for IPvAnyInterface . A PR was made as #9990.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IPv4Network is marked as incompatible to IPvAnyNetwork

3 participants