Annotated tzinfo offset example#9531
Merged
sydney-runkle merged 3 commits intopydantic:mainfrom May 31, 2024
Merged
Conversation
CodSpeed Performance ReportMerging #9531 will not alter performanceComparing Summary
|
Contributor
Author
|
Hey @sydney-runkle , this is my PR following our tzinfo conversation with @ChrisPappalardo at PyCon2024. It factors in the offset example from issue #8088 |
sydney-runkle
approved these changes
May 31, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
This is great! So excited to see annotated metadata being used in this way! Thanks for your contribution 🚀 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Added annotated tzinfo example pattern with offset building upon commit #9468
Related issue number
Related to offset discussion issue 8088
Checklist