Annotated tzinfo example#9468
Merged
sydney-runkle merged 8 commits intopydantic:mainfrom May 21, 2024
ChrisPappalardo:annotated_tzinfo_example
Merged
Annotated tzinfo example#9468sydney-runkle merged 8 commits intopydantic:mainfrom ChrisPappalardo:annotated_tzinfo_example
sydney-runkle merged 8 commits intopydantic:mainfrom
ChrisPappalardo:annotated_tzinfo_example
Conversation
CodSpeed Performance ReportMerging #9468 will not alter performanceComparing Summary
|
Contributor
Author
|
Tests pass with the following exception: |
sydney-runkle
approved these changes
May 21, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Amazing! This is such a great use case for the combination of custom validators, annotated types, and modifying schema with annotated type metadata.
Excited to have this as a reference for a future.
auto-merge was automatically disabled
May 21, 2024 14:40
Head branch was pushed to by a user without write access
sydney-runkle
approved these changes
May 21, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Nice, thanks for moving things around so this follows the wrap validator pattern!
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Add an example and a unit test for custom timezone validation.
Related issue number
#8088
Checklist