Remove contradicting comment in docstring of BaseModel.__get_pydantic_core_schema__#9448
Merged
sydney-runkle merged 1 commit intopydantic:mainfrom May 17, 2024
Merged
Conversation
The removed comment is incorrect for this is for core schema generation not for JSON schema generation. It is also not needed for the following sentence provides the needed info
CodSpeed Performance ReportMerging #9448 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR made a minor correction in the docstring of
BaseModel.__get_pydantic_core_schema__. The commit message in this PR provides the reason for the change.Related issue number
Checklist