Add warning when set "alias" in low level annontated field#9170
Merged
sydney-runkle merged 8 commits intopydantic:mainfrom May 20, 2024
Merged
Conversation
CodSpeed Performance ReportMerging #9170 will not alter performanceComparing Summary
|
Contributor
Author
|
please review. |
dmontagu
reviewed
Apr 19, 2024
Contributor
|
Great work here, thanks! Will merge once tests pass - I made a few minor modifications to function names + warning wording. |
Contributor
|
Sorry - not sure what exactly the last linting issue is with the test file - could you check locally? Other than that, we're good to merge! |
Contributor
Author
|
@sydney-runkle resolved the linting. Should be good now. |
sydney-runkle
approved these changes
May 20, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Great work here, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Add warning message when user setup annotated field with
aliaskwarg at low level. #7828.Related issue number
Checklist
Fix #7828
Selected Reviewer: @adriangb