CodSpeed Performance Report

Merging #10378 will not alter performance

_{Comparing theunkn0wn1:user/theunkn0wn1/validate_socket (b874a82) with main (7daa2cd)}

Summary

✅ 49 untouched benchmarks

Test will need to be skipped on windows; as it doesn't have sockets to begin with.
Not sure why the tests are failing on mac.

Looking good though, happy to support this once we get tests passing, etc :).

ok for the issue with the Mac tests - pytest seems to be configured wrong, the temporary paths its generating with its fixture exceed the maximum length of a socket name on that platform.
Only way i can see to fix that would be to change the pytest config to use a more sensible base directory.
the trouble? i don't have a mac to test with and don't know what a sensible base path for that platform is.
Can I ask for some pointers here?

ok for the issue with the Mac tests - pytest seems to be configured wrong, the temporary paths its generating with its fixture exceed the maximum length of a socket name on that platform.
Only way i can see to fix that would be to change the pytest config to use a more sensible base directory.
the trouble? i don't have a mac to test with and don't know what a sensible base path for that platform is.
Can I ask for some pointers here?

I'm ok only running the test on Linux. The goal isn't to test that creating sockets works, but to ensure that validate_socket works as expected when encountering a socket path.

Added condition to skip new test if not linux.
squashed commits to one.
rebased against tip of upstream main. :)

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
pydantic
types.py					1277
Project Total

This report was generated by python-coverage-comment-action

please review :)

@sydney-runkle when can i expect this change to be released? 😇

@theunkn0wn1, with our 2.10 release in late October! Feel free to install from main in the meantime :)