Skip to content

Do not add trailing commas to return type annotations using PEP 604 unions#3735

Merged
JelleZijlstra merged 1 commit into
psf:mainfrom
yilei:annret
Jun 16, 2023
Merged

Do not add trailing commas to return type annotations using PEP 604 unions#3735
JelleZijlstra merged 1 commit into
psf:mainfrom
yilei:annret

Conversation

@yilei

@yilei yilei commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

Description

Fix #3638

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@JelleZijlstra JelleZijlstra self-requested a review June 15, 2023 22:57
@github-actions

Copy link
Copy Markdown
Contributor

diff-shades reports zero changes comparing this PR (0ce244d) to main (35722df).


What is this? | Workflow run | diff-shades documentation

@JelleZijlstra JelleZijlstra merged commit 01b8d3d into psf:main Jun 16, 2023
copybara-service Bot pushed a commit to google/pyink that referenced this pull request Jun 16, 2023
Why not rebase? Black has unreleased changes in blib2to3, rebasing will make Pyink releases harder. Will wait for a new Black release before we rebase.

PiperOrigin-RevId: 540903043
copybara-service Bot pushed a commit to google/pyink that referenced this pull request Jun 16, 2023
Why not rebase? Black has unreleased changes in blib2to3, rebasing will make Pyink releases harder. Will wait for a new Black release before we rebase.

PiperOrigin-RevId: 540903043
copybara-service Bot pushed a commit to google/pyink that referenced this pull request Jun 16, 2023
Why not rebase? Black has unreleased changes in blib2to3, rebasing will make Pyink releases harder. Will wait for a new Black release before we rebase.

PiperOrigin-RevId: 540903043
copybara-service Bot pushed a commit to google/pyink that referenced this pull request Jun 16, 2023
Why not rebase? Black has unreleased changes in blib2to3, rebasing will make Pyink releases harder. Will wait for a new Black release before we rebase.

PiperOrigin-RevId: 540999761
@yilei yilei deleted the annret branch October 18, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Black adds unexpected trailing comma in return type wrapped in parenthesis

2 participants