Skip to content

Build with mypyc 1.3#3697

Merged
JelleZijlstra merged 1 commit into
psf:mainfrom
stianjensen:mypyc-upgrade-1.2
Jun 23, 2023
Merged

Build with mypyc 1.3#3697
JelleZijlstra merged 1 commit into
psf:mainfrom
stianjensen:mypyc-upgrade-1.2

Conversation

@stianjensen

@stianjensen stianjensen commented May 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Several new versions of mypyc has been released since the last upgrade, and they include some performance improvements which could make the compiled version of Black run faster.

https://mypy-lang.org/news.html

The latest version of hatch-mypyc allows being installed next the 1.x series of mypy.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@ichard26 ichard26 self-requested a review May 19, 2023 21:04
@JelleZijlstra

JelleZijlstra commented May 19, 2023

Copy link
Copy Markdown
Collaborator

Thanks! I think we should jump straight to 1.3 if possible.

@stianjensen stianjensen changed the title Build with mypyc 1.2 Build with mypyc 1.3 May 19, 2023
@stianjensen

stianjensen commented May 19, 2023

Copy link
Copy Markdown
Contributor Author

Let's try 1.3, then!

I'm not sure if any part of the mypyc release flow is really possible to test locally – from my understanding, that is only setup on CI?

@JelleZijlstra

JelleZijlstra commented May 19, 2023

Copy link
Copy Markdown
Collaborator

I believe it's testable by running cibuildwheel directly. This was discussed on our Discord (https://discord.com/channels/267624335836053506/846434317021741086/1096514507486023700).

@stianjensen
Build with mypyc 1.3
25eb12b 
Several new versions of mypyc has been released since the last upgrade, and they include some performance improvements which could make the compiled version of Black run faster.

https://mypy-lang.org/news.html

The latest version of hatch-mypyc allows being installed next the 1.x series of mypy.
@github-actions

github-actions Bot commented May 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

diff-shades reports zero changes comparing this PR (25eb12b) to main (eedfc38).

What is this? | Workflow run | diff-shades documentation

@stianjensen

stianjensen commented May 19, 2023

Copy link
Copy Markdown
Contributor Author

I believe it's testable by running cibuildwheel directly.

Great! Managed to follow those instructions and build at least a couple Linux wheels now and then test them inside a docker python image. I don't really have a rig for perf testing (only an old macbook, and building for mac required replacing my global python binary), but at the very least I managed to use my built version of black to reformat a tiny python file.

Let me know if there's anything else I can do – either upload some of my built wheels, or specific tests that would be good to perform with them.

@JelleZijlstra

JelleZijlstra commented May 19, 2023

Copy link
Copy Markdown
Collaborator

Thanks, that sounds great! @ichard26 is our mypyc expert and he tagged himself, so I'll give him some time to add any feedback.

@JelleZijlstra

JelleZijlstra commented Jun 23, 2023

Copy link
Copy Markdown
Collaborator

It's been a month, let's merge this.

@JelleZijlstra JelleZijlstra merged commit c732a1f into psf:main Jun 23, 2023
@stianjensen stianjensen deleted the mypyc-upgrade-1.2 branch June 23, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ichard26 ichard26 Awaiting requested review from ichard26

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stianjensen @JelleZijlstra