Remove unused python_protobuf.{cc,h}#8513
Merged
acozzette merged 2 commits intoprotocolbuffers:masterfrom Apr 19, 2021
Merged
Conversation
e6db597 to
f38d528
Compare
f38d528 to
311cb41
Compare
Contributor
Author
|
As I see, the file still participates in build: I wonder how it this works. |
|
I think this line probably just needs to be deleted. |
7e22bcb to
af4e4d4
Compare
Contributor
Author
|
@acozzette, I see that google/protobuf/util/init.py does not makes anything useful either. Could you check if it can be removed too? |
|
I'm not sure. @anandolee Do you know if that file can be removed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #8510.