Skip to content

Fix for JSON serialization of 0/empty-valued wrapper types#7198

Merged
haberman merged 2 commits intoprotocolbuffers:masterfrom
haberman:ruby-json-bugfix
Feb 11, 2020
Merged

Fix for JSON serialization of 0/empty-valued wrapper types#7198
haberman merged 2 commits intoprotocolbuffers:masterfrom
haberman:ruby-json-bugfix

Conversation

@haberman
Copy link
Copy Markdown
Member

Fixes: #6903
Fixes: #6754

@haberman haberman merged commit f2c5ee5 into protocolbuffers:master Feb 11, 2020
rafi-kamal pushed a commit that referenced this pull request Feb 12, 2020
* Fixed Ruby JSON serialization of 0/empty wrapper fields.

* Removed newly-passing conformance tests from the failure list.
rafi-kamal pushed a commit that referenced this pull request Feb 12, 2020
* Fixed Ruby JSON serialization of 0/empty wrapper fields.

* Removed newly-passing conformance tests from the failure list.
rafi-kamal added a commit that referenced this pull request Feb 12, 2020
…7204)

* Fixed Ruby JSON serialization of 0/empty wrapper fields.

* Removed newly-passing conformance tests from the failure list.

Co-authored-by: Joshua Haberman <jhaberman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Ruby] Encoding JSON produces invalid JSON with empty StringValue wrapper. Ruby: wrapper types initialized to zero do not correctly serialize as json

4 participants