fix(javascript): correctly handle parentheses between await and optional chaining#6087
Merged
alexander-akait merged 1 commit intomasterfrom Apr 30, 2019
Merged
fix(javascript): correctly handle parentheses between await and optional chaining#6087alexander-akait merged 1 commit intomasterfrom
alexander-akait merged 1 commit intomasterfrom
Conversation
alexander-akait
commented
Apr 26, 2019
| (list || list2)?.[list || list2]; | ||
|
|
||
| async function HelloWorld() { | ||
| var x = await (foo.bar.blah)?.hi; |
Member
Author
There was a problem hiding this comment.
Not right places 
WIP
19e9e64 to
9c663c6
Compare
This comment has been minimized.
This comment has been minimized.
|
Can't wait for this 🤖 mergemergemergemerge |
Member
Author
|
/cc @j-f1 |
j-f1
approved these changes
Apr 29, 2019
Member
j-f1
left a comment
There was a problem hiding this comment.
LGTM — just make sure you change the PR title to reflect the contents of the PR before merging.
Member
Author
|
Feel free to feedback |
|
@evilebottnawi do u know about the process required to get it VsCode ? i guess it has to be published to npm and the extension updated by maintener ? |
Member
Author
|
@Sceat I can't understand you |
|
@evilebottnawi just want to know the ETA for the prettier vscode extension with this fix |
Member
|
We do releases approximately every 1.5 months, and I believe the VS Code extension uses whatever version you have installed, so once we release a new version, the VS Code extension will be updated. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/directory)CHANGELOG.unreleased.mdfile following the template.✨Try the playground for this PR✨
fixes #5857