fix(glimmer): {{else}}{{#if}} into {{else if}} merging#6080
Merged
alexander-akait merged 4 commits intoprettier:masterfrom May 2, 2019
Merged
fix(glimmer): {{else}}{{#if}} into {{else if}} merging#6080alexander-akait merged 4 commits intoprettier:masterfrom
alexander-akait merged 4 commits intoprettier:masterfrom
Conversation
49bf6bd to
9a3ee3d
Compare
9a3ee3d to
6df3a03
Compare
alexander-akait
requested changes
Apr 25, 2019
Member
alexander-akait
left a comment
There was a problem hiding this comment.
Thanks!
Need add note in changelog
Collaborator
Author
|
@evilebottnawi done, sorry for that |
ea48afb to
26e6d8e
Compare
```
{{#if a}}
a
{{else}}
{{#if c}}
c
{{/if}}
e
{{/if}}
```
should be left untouched. Instead, it is turned into:
```
{{#if a}}
a
{{else if c}}
c
e
{{/if}}
```
Collaborator
Author
|
@evilebottnawi |
Member
|
@dcyriller Thanks, can you fix CI? |
Collaborator
Author
|
@evilebottnawi CI is now 🍏 I see that you squash the commits, so I don't bother to remove the last one (that was empty). |
Member
|
/cc @prettier/core we need rule about merging (minimum 2 approve from core as example) |
lipis
approved these changes
May 1, 2019
suchipi
approved these changes
May 1, 2019
1 task
This was referenced Jun 5, 2019
This was referenced Jun 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The first commit highlights the issue. The second fixes it.
The following code should be left untouched:
Instead, it was turned into:
Checks
CHANGELOG.unreleased.mdfile following the template.Playground
✨Try the playground for this PR✨