Skip to content

Fixup getSupportInfo for babylon parser prior to 1.16.0#5826

Merged
azz merged 4 commits intoprettier:masterfrom
azz:support-info-babel
Feb 3, 2019
Merged

Fixup getSupportInfo for babylon parser prior to 1.16.0#5826
azz merged 4 commits intoprettier:masterfrom
azz:support-info-babel

Conversation

@azz
Copy link
Copy Markdown
Member

@azz azz commented Feb 3, 2019 •
edited
Loading

This undoes an accidental breaking change where prettier.getSupportInfo('1.0.0') would report supporting the babel parser instead of babylon.

Fixes #5822

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If not an internal change) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

azz
azz commented Feb 3, 2019
View reviewed changes
tests_integration/__tests__/__snapshots__/support-info.js.snap
\\"Less\\": Array [
\\"less\\",
],
+ \\"Lightning Web Components\\": Array [
Copy link
Copy Markdown
Member Author

@azz azz Feb 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is correct as it is unreleased?

@azz azz merged commit 2982dcd into prettier:master Feb 3, 2019
@azz azz deleted the support-info-babel branch February 3, 2019 10:58
@azz
Copy link
Copy Markdown
Member Author

azz commented Feb 3, 2019

Any idea why I'm getting build failure emails from CircleCI? Is Circle even in use anymore?

image

@ikatyang
Copy link
Copy Markdown
Member

ikatyang commented Feb 3, 2019 •
edited
Loading

Circle was removed in #5611, but it seems we forgot to remove their webhooks.

EDIT: I've disabled them.

@azz
Copy link
Copy Markdown
Member Author

azz commented Feb 3, 2019

Thanks! Azure pipelines look pretty neat. Are there any issues I should read through to catch up on current state of CI?

@ikatyang
Copy link
Copy Markdown
Member

ikatyang commented Feb 3, 2019

Azure Pipelines was introduced in #5410 and then tweaked in #5611/#5498, these 3 PRs should include everything about our current CI state. Basically, it's just migrated from Circle/Travis to Azure Pipelines with the same test steps, the docs for Azure Pipelines could be found here.

ikatyang pushed a commit that referenced this pull request Feb 3, 2019
@azz @ikatyang
Fixup getSupportInfo for babylon parser prior to 1.16.0 (#5826)
29799e5 
This undoes an accidental breaking change where `prettier.getSupportInfo('1.0.0')` would report supporting the `babel` parser instead of `babylon`.

Fixes #5822
@ikatyang ikatyang added this to the 1.16.4 milestone Feb 3, 2019
@automatops automatops mentioned this pull request Feb 3, 2019
Merged
1 task
@ghost ghost mentioned this pull request Feb 3, 2019
Merged
1 task
@xcomponentadmin xcomponentadmin mentioned this pull request Feb 3, 2019
Merged
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label May 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ikatyang ikatyang ikatyang approved these changes

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

1.16.4

Development

Successfully merging this pull request may close these issues.

getSupportInfo misinform about babel/babylon

2 participants

@azz @ikatyang