Skip to content

fix(javascript): add necessary parentheses for decorators#5785

Merged
ikatyang merged 5 commits intoprettier:masterfrom
ikatyang:fix/javascript/decorator-parens
Jan 21, 2019
Merged

fix(javascript): add necessary parentheses for decorators#5785
ikatyang merged 5 commits intoprettier:masterfrom
ikatyang:fix/javascript/decorator-parens

Conversation

@ikatyang
Copy link
Copy Markdown
Member

@ikatyang ikatyang commented Jan 21, 2019

Fixes #5777

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If not an internal change) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@ikatyang ikatyang added this to the 1.16.1 milestone Jan 21, 2019
@ikatyang ikatyang merged commit 2002ce0 into prettier:master Jan 21, 2019
@ikatyang ikatyang deleted the fix/javascript/decorator-parens branch January 21, 2019 16:54
@automatops automatops mentioned this pull request Jan 22, 2019
Merged
1 task
@ghost ghost mentioned this pull request Jan 22, 2019
Merged
1 task
@xcomponentadmin xcomponentadmin mentioned this pull request Jan 22, 2019
Merged
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Apr 21, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@duailibe duailibe duailibe approved these changes

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

1.16.1

Development

Successfully merging this pull request may close these issues.

Use of nested decorators breaks

2 participants

@ikatyang @duailibe