Skip to content

fix(javascript): do not attach to block if it's not behind right func paren#5435

Merged
ikatyang merged 3 commits intoprettier:masterfrom
ikatyang:fix/javascript/func-last-param-comment
Nov 10, 2018
Merged

fix(javascript): do not attach to block if it's not behind right func paren#5435
ikatyang merged 3 commits intoprettier:masterfrom
ikatyang:fix/javascript/func-last-param-comment

Conversation

@ikatyang
Copy link
Copy Markdown
Member

@ikatyang ikatyang commented Nov 10, 2018

Fixes #5403

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@ikatyang ikatyang added this to the 1.15.2 milestone Nov 10, 2018
@ikatyang
Copy link
Copy Markdown
Member Author

ikatyang commented Nov 10, 2018

This one should be the last fix in 1.15.2, I'll release 1.15.2 once they're approved.

@ikatyang ikatyang merged commit e0f74cb into prettier:master Nov 10, 2018
@ikatyang ikatyang deleted the fix/javascript/func-last-param-comment branch November 10, 2018 16:10
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

1.15.2

Development

Successfully merging this pull request may close these issues.

2 participants

@ikatyang @alexander-akait