fix(flow,ts): consistent interface and remove unnecessary indent for extends by ikatyang · Pull Request #5432 · prettier/prettier

ikatyang · 2018-11-10T04:09:54Z

Fixes #5431

force-break Flow interfaces to be consistent with TS interfaces
do not indent interface extends if there's only one extend member
correctly distinguish module and namespace for TSModuleDeclaration
(module X {} was printed as namespace X {})

I’ve added tests to confirm my change works.
(If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
I’ve read the contributing guidelines.

src/language-js/printer-estree.js

ikatyang added 4 commits November 10, 2018 11:50

test: add tests

e7f1cb1

fix: break Flow interface and correctly print "module" for TS

5eeeb13

fix: do not indent extends if there's only one extend

6c15164

test: update snapshots

9f16151

ikatyang added this to the 1.15.2 milestone Nov 10, 2018

j-f1 approved these changes Nov 10, 2018

View reviewed changes

src/language-js/printer-estree.js Show resolved Hide resolved

refactor

f258c29

ikatyang merged commit 6cedf7d into prettier:master Nov 10, 2018

ikatyang deleted the fix/flow-ts/interface branch November 10, 2018 16:15

lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 8, 2019

lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019

Provide feedback