Handle reselect's createSelector as function composition#5430
Merged
suchipi merged 1 commit intoprettier:masterfrom Nov 10, 2018
Merged
Handle reselect's createSelector as function composition#5430suchipi merged 1 commit intoprettier:masterfrom
suchipi merged 1 commit intoprettier:masterfrom
Conversation
Contributor
Author
|
CI failures seem unrelated |
suchipi
approved these changes
Nov 10, 2018
Member
|
Looks great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #5285; initially I thought this was a feature but after seeing that #4431 already added special handling for similar function composition functions, including one from redux, I think adding support for reselect's
createSelectorcould be considered a fix (especially since it's an official library in the same github org as redux)✨Try the playground for this PR✨