Skip to content

fix(javascript): inline property decorator should stay inline (part 2)#5423

Merged
ikatyang merged 6 commits intoprettier:masterfrom
ikatyang:fix/javascript/inline-decorator
Nov 10, 2018
Merged

fix(javascript): inline property decorator should stay inline (part 2)#5423
ikatyang merged 6 commits intoprettier:masterfrom
ikatyang:fix/javascript/inline-decorator

Conversation

@ikatyang
Copy link
Copy Markdown
Member

@ikatyang ikatyang commented Nov 9, 2018 •
edited
Loading

Fixes cases mentioned in #5360 (comment)

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@ikatyang ikatyang added this to the 1.15.2 milestone Nov 9, 2018
@ikatyang ikatyang mentioned this pull request Nov 9, 2018
Closed
@ikatyang ikatyang changed the title fix(javascript): inline property decorator should stay inline (part 2) fix(javascript): inline decorator should stay inline Nov 9, 2018
ikatyang
ikatyang commented Nov 9, 2018
View reviewed changes
docs/rationale.md
}
```

There's one exception: classes. We don't think it ever makes sense to inline the decorators for them, so they are always moved to their own line.
Copy link
Copy Markdown
Member Author

@ikatyang ikatyang Nov 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--> #5360 (comment)

@ikatyang ikatyang requested a review from lydell November 9, 2018 12:38
duailibe
duailibe approved these changes Nov 9, 2018
View reviewed changes
Copy link
Copy Markdown
Collaborator

@duailibe duailibe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the property changes, but the classes I don't think we should change 🤷‍♂️

It was one person who "complained" and also noted the mobx docs have example of both kinds, but I'm not willing do die on any particular hill these days, so you all are free to decide which is best.

@ikatyang
Copy link
Copy Markdown
Member Author

ikatyang commented Nov 9, 2018

OK, let's bisect them from this PR and see how people think about it.

@ikatyang ikatyang changed the title fix(javascript): inline decorator should stay inline fix(javascript): inline property decorator should stay inline (part 2) Nov 9, 2018
@ikatyang ikatyang merged commit 8b1260a into prettier:master Nov 10, 2018
@ikatyang ikatyang deleted the fix/javascript/inline-decorator branch November 10, 2018 08:44
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@existentialism existentialism existentialism approved these changes

@duailibe duailibe duailibe approved these changes

@lydell lydell lydell approved these changes

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

1.15.2

Development

Successfully merging this pull request may close these issues.

4 participants

@ikatyang @existentialism @duailibe @lydell