Skip to content

fix(markdown): handle CRLF correctly#5414

Merged
ikatyang merged 2 commits intoprettier:masterfrom
ikatyang:fix/markdown/crlf
Nov 10, 2018
Merged

fix(markdown): handle CRLF correctly#5414
ikatyang merged 2 commits intoprettier:masterfrom
ikatyang:fix/markdown/crlf

Conversation

@ikatyang
Copy link
Copy Markdown
Member

@ikatyang ikatyang commented Nov 9, 2018

Fixes #5413

We should figure out a better way to completely get rid of CRLF, but I think it needs more time since we don't want to break something like rangeFormat or cusorOffset.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@ikatyang ikatyang added this to the 1.15.2 milestone Nov 9, 2018
@schallm
Copy link
Copy Markdown

schallm commented Nov 9, 2018

Not sure if this should work (I have never used the playground before), but I tried the following markdown (small version of same issue we are currently seeing) in the playground:

- Option 1
    ```cmd
    dir c:\
    dir d:\
    ```

and received the following error in the output frame:

SyntaxError: Unexpected token, expected ";" (1:10)
> 1 | - Option 1
    |          ^
  2 |     ```cmd
  3 |     dir c:\
  4 |     dir d:\

@j-f1
Copy link
Copy Markdown
Member

j-f1 commented Nov 9, 2018

@schallm You have to select the markdown parser for it to work.

@ikatyang ikatyang merged commit 2bb95d8 into prettier:master Nov 10, 2018
@ikatyang ikatyang deleted the fix/markdown/crlf branch November 10, 2018 16:24
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lipis lipis lipis approved these changes

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

1.15.2

Development

Successfully merging this pull request may close these issues.

4 participants

@ikatyang @schallm @j-f1 @lipis