Skip to content

fix(angular): handle parens in ng expression correctly#5387

Merged
ikatyang merged 2 commits intoprettier:masterfrom
ikatyang:fix/angular/handle-parens-in-ng-expr
Nov 8, 2018
Merged

fix(angular): handle parens in ng expression correctly#5387
ikatyang merged 2 commits intoprettier:masterfrom
ikatyang:fix/angular/handle-parens-in-ng-expr

Conversation

@ikatyang
Copy link
Copy Markdown
Member

@ikatyang ikatyang commented Nov 8, 2018

Fixes #5367

See prettier/angular-estree-parser#22.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

Try the playground for this PR

@ikatyang ikatyang added this to the 1.15.2 milestone Nov 8, 2018
@ikatyang ikatyang merged commit 7f472d7 into prettier:master Nov 8, 2018
@ikatyang ikatyang deleted the fix/angular/handle-parens-in-ng-expr branch November 8, 2018 16:06
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants